• sreeram@chromium.org's avatar
    Always call WasShown() before trying to paint. · a87edf63
    sreeram@chromium.org authored
    See the bug link for details on the crash that this CL is attempting to fix.
    Although I haven't been able to reproduce the crash locally, my intuition is
    that, when we call window->ShowInstant(), sometimes it tries to paint, and
    since the RenderWidgetHostView hasn't yet been told that it's being shown, it
    fails the DCHECK(). So, reorder the calls so that WasShown() is always called
    before any change to the Instant overlay layout (ShowInstant/HideInstant).
    
    BUG=143207
    R=sky@chromium.org
    TEST=Watch try bots/waterfall; Instant shouldn't fire this DCHECK().
    
    Review URL: https://chromiumcodereview.appspot.com/10828374
    
    git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152348 0039d316-1c4b-4281-b951-d872f2087c98
    a87edf63
instant_browsertest.cc 33 KB