• Anastasiia Nikolaienko's avatar
    Revert "Fix Mirror cookie validity mismatch" · a896e472
    Anastasiia Nikolaienko authored
    This reverts commit 30fd9e19.
    
    Reason for revert: submitting https://crrev.com/c/1871591 instead (
    where we call LogOutAllAccounts directly instead of changing the logic
    of AccountReconcilor).
    
    Original change's description:
    > Fix Mirror cookie validity mismatch
    >
    > In certain cases, Gaia's /ListAccounts APIs claims accounts to be in a
    > valid state when they are actually invalid. This causes issues with
    > account reconciliation because |AccountReconcilor| uses /ListAccounts as
    > the source of truth and is unable to detect this state.
    > In this state, certain Google properties like Gmail for example send a
    > Mirror re-authentication header for the offending account. However, even
    > after the user re-authenticates the account, account reconciliation ends
    > up being a no-op because the reconcilor thinks that the user's cookies
    > are valid and there is nothing to reconcile.
    >
    > Fix this by storing some flags in |CookieReminter| which are set when
    > we receive Mirror re-authentication headers from Gaia, and are cleared
    > when the next reconciliation cycle begins.
    >
    > This is a temporary fix until we can submit https://crrev.com/c/1871591.
    >
    > Bug: 1012649
    > Change-Id: I04fd971cdc788094f038ee808b4a38003ef48e22
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883652
    > Reviewed-by: David Roger <droger@chromium.org>
    > Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#710870}
    
    Bug: 1012649
    Change-Id: I2873677ac23f3ea98930603f0c1615a59fa8ce97
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901036Reviewed-by: default avatarDavid Roger <droger@chromium.org>
    Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#713400}
    a896e472
BUILD.gn 4.74 KB