• Lukasz Anforowicz's avatar
    Consolidate http and non-http WillCreateURLLoaderFactory calls. · a9ac9036
    Lukasz Anforowicz authored
    This CL deduplicates ContentBrowserClient::WillCreateURLLoaderFactory
    and devtools_instrumentation::WillCreateURLLoaderFactory calls made by
    RenderFrameHostImpl from RenderFrameHostImpl::CommitNavigation (for
    |non_network_url_loader_factories_|) and from
    RenderFrameHostImpl::CreateNetworkServiceDefaultFactoryInternal.
    
    This deduplication will help in a follow-up CL that changes the lifetime
    of FileURLLoaderFactory and needs to add one more call to
    WillCreateURLLoaderFactory - see https://crrev.com/c/2305213/11.
    
    This CL ignores RFHI callers of
    ContentBrowserClient::WillCreateURLLoaderFactory that don't call into
    devtools_instrumentation (AppCache and WebUI).  Omitting
    devtools_instrumentation from these callers is intentional (as discussed
    in the code review).
    
    Bug: 1106995
    Change-Id: I9888a39f3a7169399e535b3c68eae6fc53610b18
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321538
    Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
    Reviewed-by: default avatarAndrey Kosyakov <caseq@chromium.org>
    Reviewed-by: default avatarDmitry Gozman <dgozman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#792365}
    a9ac9036
render_frame_host_impl.h 142 KB