GitLab

This reverts commit ac56b3e7.

Reason for revert: PhoneHubUiControllerTest.NotEligibleForFeature
fails on msan builds:
$ autoninja -C out/chromeos_msan ash_unittests && ./out/chromeos_msan/ash_unittests --gtest_filter="*PhoneHubUiControllerTest*"

[==========] Running 9 tests from 1 test suite.
[----------] Global test environment set-up.
[----------] 9 tests from PhoneHubUiControllerTest
[ RUN      ] PhoneHubUiControllerTest.NotEligibleForFeature
==1672876==WARNING: MemorySanitizer: use-of-uninitialized-value

https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/20740
PhoneHubUiControllerTest.BluetoothOff
PhoneHubUiControllerTest.NotEligibleForFeature
PhoneHubUiControllerTest.OnboardingNotEligible
PhoneHubUiControllerTest.PhoneConnected
PhoneHubUiControllerTest.PhoneConnecting
PhoneHubUiControllerTest.PhoneConnectingForOnboarding
PhoneHubUiControllerTest.PhoneDisconnected
PhoneHubUiControllerTest.ShowOnboardingUi_WithPhone
PhoneHubUiControllerTest.ShowOnboardingUi_WithoutPhone

Original change's description:
> [CrOS PhoneHub] Add PhoneHubUiController.
>
> This class translates the PhoneHubManager state into the corresponding
> UI state and view that is shown in the tray bubble. Each state has
> it's own view class and the PhoneHubTray bubble transitions through
> these content views as the UI state changes.
>
> This CL also refactors PhoneConnectedView into it's own class.
>
> BUG=1106937,1126208
>
> Change-Id: Ie012077a1905f80be91fbfb0b084d89219bd6c26
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427060
> Commit-Queue: Tim Song <tengs@chromium.org>
> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#810942}

TBR=khorimoto@chromium.org,tengs@chromium.org,leandre@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1106937
Bug: 1126208
Change-Id: Ibd11174488010a7b210896d8f16943cfba90f918
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434010Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Johann Koenig <johannkoenig@google.com>
Commit-Queue: Johann Koenig <johannkoenig@google.com>
Cr-Commit-Position: refs/heads/master@{#811100}