• Kunihiko Sakamoto's avatar
    Revert "Introduce partially initialized holding space items" · aa4105d2
    Kunihiko Sakamoto authored
    This reverts commit 314e453b.
    
    Reason for revert: HoldingSpaceTrayTest.ShowTrayButtonOnFirstUse is crashing on linux-chromeos-dbg:
    https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/21023
    
    
    Original change's description:
    > Introduce partially initialized holding space items
    >
    > Introduces a concept of partially initialized HoldingSpaceItem - this
    > state will be used when loading items from persistent storage in case
    > the item file system URL cannot immediately be resolved (e.g. if the
    > associated mount point hasn't been loaded yet).
    > HoldingSpacePersistenceDelegate will deserialize persisted items into
    > partial state when they are first loaded from the storage, and
    > "finalize" them when their file system URL can be resolved.
    >
    > Compared to an alternative approach where items whose initialization has
    > to be deferred, this approach keeps the order in which items are added
    > to the model.
    >
    > Updates holding space UI not to show partially initialized items.
    >
    > BUG=1140150
    >
    > Change-Id: Ie19997ec02f6323434f4053f6ba41a2998e72efa
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493323
    > Commit-Queue: Toni Baržić <tbarzic@chromium.org>
    > Reviewed-by: David Black <dmblack@google.com>
    > Cr-Commit-Position: refs/heads/master@{#821024}
    
    TBR=tbarzic@chromium.org,dmblack@google.com
    
    Change-Id: Ie916d1b4f15eab360b7124c481105733736c671c
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 1140150
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500688Reviewed-by: default avatarKunihiko Sakamoto <ksakamoto@chromium.org>
    Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#821111}
    aa4105d2
recent_files_container.h 2.17 KB