• Ned Nguyen's avatar
    Revert "Migrate consumers of SigninManager::IsAllowedUsername()" · aabacf9e
    Ned Nguyen authored
    This reverts commit 198eca95.
    
    Reason for revert: breaking GPU Linux Builder
    
    Original change's description:
    > Migrate consumers of SigninManager::IsAllowedUsername()
    > 
    > Use identity::IsUsernameAllowedByPattern() instead so that we can migrate
    > those consumers entirely to the IdentityManager in follow-up patches.
    > 
    > Also, in order to make it explicit that this API should not be used any
    > more, make SigninManager::IsAllowedUsername() a private method and friend
    > it with the relevant test cases from SigninManagerTest, so that it can
    > only be used from there. And while at it, also remove some stale lines
    > "friending" SigninManager with test cases that no longer exist.
    > 
    > Bug: 890794, 890815, 906085
    > Change-Id: Id8a72b0efd89818e02c6d1e73aac1451207b9625
    > Reviewed-on: https://chromium-review.googlesource.com/c/1346409
    > Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
    > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
    > Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
    > Cr-Commit-Position: refs/heads/master@{#611704}
    
    TBR=blundell@chromium.org,msarda@chromium.org,sdefresne@chromium.org,mario@igalia.com
    
    Change-Id: I8172674e32d7671868fa5374a9457abd6413321e
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 890794, 890815, 906085
    Reviewed-on: https://chromium-review.googlesource.com/c/1354121Reviewed-by: default avatarNed Nguyen <nednguyen@google.com>
    Commit-Queue: Ned Nguyen <nednguyen@google.com>
    Cr-Commit-Position: refs/heads/master@{#611710}
    aabacf9e
signin_ui_util.cc 10.8 KB