GitLab

This patch stops removing trailing collapsible spaces at the
end of inline formatting contexts.

CSS defines to remove trailing collapsible spaces for each line.
Before this patch, CollectInlines() removes them before line
break as an micro-optimization because the end of an inline
formatting context is also the end of lines.

It turned out that this may prevent the re-use of NGInlineItem
(CL:986982) in some common cases, and since the re-use is a
great performance win, this micro-optimization turned out to
harmful.

Note, there are 19 tests that have 1px differences, probably
because we don't reshape when removing trailing spaces. Since
we already do this in HandleTrailingSpaces, rebaseline in this
patch but I'll work in following patches.

Bug: 636993
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Iff30d0cb05b4b80950c0d6da10ce8f6eff23a61a
Reviewed-on: https://chromium-review.googlesource.com/1022191
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555320}