• Brandon Walderman's avatar
    Add wrapper class for devtools endpoint URLs. · ab7c5b41
    Brandon Walderman authored
    This change moves the logic for constructing DevTools endpoint URLs into
    a common location (DevToolsHttpEndpoint). Call sites that were
    previously building URL strings directly can now call the appropriate
    method on DevToolsHttpEndpoint instead. For example, List() returns
    an endpoint's /json/list URL.
    
    A DevToolsHttpEndpoint can be constructed from a NetAddress for the
    common case where the endpoint is running on localhost on a certain
    port. It can also be constructed from a URL with a path prefix. The
    prefix will be included in all URLs for that endpoint.
    
    This is mainly to support some downstream features in MSEdgeDriver that
    rely on devtools endpoints with path prefixes and which may be served
    over HTTPS. There is no functional change to ChromeDriver. Just some
    refactoring.
    
    Bug: 1016888
    Change-Id: I50dc97f23637f58f972e7f5a5807e74a7af5f69a
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874200Reviewed-by: default avatarJohn Chen <johnchen@chromium.org>
    Commit-Queue: Brandon Walderman <brwalder@microsoft.com>
    Cr-Commit-Position: refs/heads/master@{#708813}
    ab7c5b41
chrome_launcher.cc 44.2 KB