• James Cook's avatar
    Revert "chromeos: Move AXHostService into ash" · abc90186
    James Cook authored
    This reverts commit e392dddd.
    
    Reason for revert:
    Follow-up design discussions with dmazzoni and dtseng suggest that
    this might not be the right direction to go.
    
    Instead we might want to use AXHostService as the way that both
    out-of-process ash and remote app windows/widgets talk to the
    browser. We may also have a different mechanism for assigning
    AX child tree IDs per-widget.
    
    Original change's description:
    > chromeos: Move AXHostService into ash
    > 
    > This is a step toward supporting multiple remote apps and widgets. We
    > need this for browser windows under single-process-mash.
    > 
    > Under mash the ash process is responsible for top-level window creation
    > for remote apps. It will need to route accessibility actions (like hit
    > testing) to the correct remote app. Likewise it manages window frames
    > and focus. Therefore it should own the mojo AXHostService, not the
    > browser.
    > 
    > Accessibility events from the remote app must be routed out of ash
    > into chrome to the accessibility extension. For now we do this with
    > the in-process AccessibilityDelegate. I didn't introduce a new delegate
    > because the mojo service is lazily created and it's hard to connect
    > a new delegate at startup. Subsequent CLs will:
    > * Always create the service at ash startup
    > * Convert the delegate methods to mojo
    > 
    > See go/mash-ax-node-tree for the full plan.
    > 
    > Bug: 888147
    > Test: ash_unittests, manually use ChromeVox and STS with shortcut viewer
    > Change-Id: Ia9e63689a8cb407b66397778be4617479fdf6c92
    > Reviewed-on: https://chromium-review.googlesource.com/1249920
    > Commit-Queue: James Cook <jamescook@chromium.org>
    > Reviewed-by: Scott Violet <sky@chromium.org>
    > Reviewed-by: David Tseng <dtseng@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#594949}
    
    TBR=jamescook@chromium.org,sky@chromium.org,dtseng@chromium.org
    
    Change-Id: I156656b5114a28693308252ee531bbf4c3db867a
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 888147
    Reviewed-on: https://chromium-review.googlesource.com/1252629Reviewed-by: default avatarJames Cook <jamescook@chromium.org>
    Commit-Queue: James Cook <jamescook@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#595203}
    abc90186
default_accessibility_delegate.h 1.01 KB