• Xing Liu's avatar
    Revert "Read later: Fix crash and check URL scheme when adding a reading list." · abd87a46
    Xing Liu authored
    This reverts commit 68ff3a4c.
    
    Reason for revert: BookmarkBridgeTest is batched running on official
    bot with @Batch annotation, suspect batched tests don't load feature
    flag correctly, which make us to load EmptyReadingListManager in cc.
    
    Original change's description:
    > Read later: Fix crash and check URL scheme when adding a reading list.
    >
    > We should expect ReadingListManager::Add to return nullptr when the
    > title can't be parsed as UTF strings, or the URL scheme is not http or
    > https.
    >
    > Bug: 1157808,1163225
    > Change-Id: I1d4e9ceb74f2821bda19907936d43919c8cc9dbd
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611628
    > Reviewed-by: David Trainor <dtrainor@chromium.org>
    > Commit-Queue: Xing Liu <xingliu@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#840779}
    
    TBR=dtrainor@chromium.org,shaktisahu@chromium.org,wylieb@chromium.org,xingliu@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 1157808
    Bug: 1163225
    Change-Id: I02e68dd57ccd1fa5d8edec4a0799c80c182b29b8
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616960Reviewed-by: default avatarXing Liu <xingliu@chromium.org>
    Reviewed-by: default avatarTommy Nyquist <nyquist@chromium.org>
    Commit-Queue: Xing Liu <xingliu@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#841291}
    abd87a46
bookmark_bridge.cc 43 KB