GitLab

FidoReturnCode is a unified namespace for any higher-level status of a
FidoRequestHandler. This was somewhat convient because security key
operations share certain failure modes (e.g. kSuccess,
kInvalidAuthenticatorResponse or kSoftPINBlock). On the other hand, it
meant that users of each FidoRequestHandler needed to implicitly know
which subset of FidoReturnCode was applicable to the particular
subclass.

This change replaces FidoReturnCode with separate status enums for each
request handler. This gets us better type safety and smaller
"switch(status) { ... }" blocks at the expense of having to duplicate
the few common status values across request handlers.

Bug: 876109

Change-Id: Ic0f5bfc08d6c2d4186bf4e2ca9bf99edf0bf6c87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774825
Commit-Queue: Martin Kreichgauer <martinkr@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Reviewed-by: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#692170}