• Jérôme Lebel's avatar
    [iOS] Adding implementation for 'Settings' link in first run · ac4ae1e6
    Jérôme Lebel authored
    This patch implements the advanced settings sign-in for the first run
    sign-in.
    
    SigninCoordinatorCompletionCallback is updated from:
     typedef void (^SigninCoordinatorCompletionCallback)(
         SigninCoordinatorResult signinResult,
         ChromeIdentity* identity);
    to:
    using SigninCoordinatorCompletionCallback =
        void (^)(SigninCoordinatorResult result,
                 SigninCompletionInfo* info);
    
    The |SigninCompletionInfo| is a class that owns 2 values:
     + |identity|
     + |signinCompletionAction|
    
    SigninCompletionAction is an enum 2 values:
     + SigninCompletionActionNone
     + SigninCompletionActionNeedsAdvancedSettingsSignin
    
    The seconde value is only used for the first run sign-in since it
    can't open the advanced settings sign-in as long as the first run is
    not finished.
    
    Bug: 971989
    Change-Id: Id9041def2bf872c0c10b7d21d7bcfe42eff7960e
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130852
    Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
    Reviewed-by: default avatarSylvain Defresne <sdefresne@chromium.org>
    Reviewed-by: default avatarNohemi Fernandez <fernandex@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#757020}
    ac4ae1e6
scene_controller.mm 70.1 KB