• Bruce Dawson's avatar
    Revert "Check for LNK1201 and retry links when it occurs" · ac6758ac
    Bruce Dawson authored
    This reverts commit 798beff1.
    
    Reason for revert: The original bug has been made irrelevant by the
    switch to lld, so this workaround is no longer needed. Additionally,
    crbug.com/817797 reports a failure sort of *caused* by this
    workaround.
    
    Original change's description:
    > Check for LNK1201 and retry links when it occurs
    >
    > LNK1201 seems to be happening increasingly frequently on our debug x64
    > builds for no clear reason. Subsequent builds tend to succeed so this
    > change updates our link wrapper to retry links when this error is hit.
    >
    > This retry logic may solve the problem. If not then it gives us more
    > evidence about the problem, including a backup copy of the PDB that
    > might be helpful in investigating.
    >
    > Bug: 782660
    > Change-Id: Iad60648425a01e07a20d108fcc5b74acaead9ee8
    > Reviewed-on: https://chromium-review.googlesource.com/769333
    > Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
    > Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#516769}
    
    R=dpranke@chromium.org,brucedawson@chromium.org
    
    Bug: 782660,817797
    Change-Id: Ifd03fecabdb462328898c7ef5253406cab2c570c
    Reviewed-on: https://chromium-review.googlesource.com/1103377
    Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
    Reviewed-by: default avatarDirk Pranke <dpranke@chromium.org>
    Reviewed-by: default avatarBruce Dawson <brucedawson@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#568070}
    ac6758ac
tool_wrapper.py 10.1 KB