• rsesek's avatar
    Revert of [Mac/GN] Explicitly link ApplicationServices wherever CoreGraphics... · ac799c2f
    rsesek authored
    Revert of [Mac/GN] Explicitly link ApplicationServices wherever CoreGraphics is linked. (patchset #2 id:20001 of https://codereview.chromium.org/2092513002/ )
    
    Reason for revert:
    After https://crrev.com/42e3c3e7125d the build warns if it detects this incompatibility.
    
    Original issue's description:
    > [Mac/GN] Explicitly link ApplicationServices wherever CoreGraphics is linked.
    >
    > The 10.11 SDK has an incompatibility with a OS X 10.7 deployment target.
    > ApplicationServices re-exports CoreGraphics, but due to a bug, the dylib
    > compatibility version from the re-exported framework gets confused with
    > the version of the framework doing the re-export.
    >
    > This only manifests itself in the component build because individual
    > components depend on CoreGraphics directly instead of ApplicationServices.
    > In the static library build, the transitive collection of libs ensures that
    > ApplicationServices gets linked before CoreGraphics when linking the
    > Chromium Framework, so this doesn't occur.
    >
    > To hack around the issue, specify ApplicationServices in libs ahead of
    > CoreGraphics so that the correct compatibility version is picked up. After
    > the deployment is updated to 10.8+ (https://crbug.com/580152) these hacks
    > can be removed.
    >
    > BUG=620127
    > R=mark@chromium.org
    > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
    >
    > Committed: https://chromium.googlesource.com/chromium/src/+/5f7bc190c7ffeda2a2c56161b371bc16750fac2c
    
    TBR=mark@chromium.org
    # Not skipping CQ checks because original CL landed more than 1 days ago.
    BUG=620127
    
    Review-Url: https://codereview.chromium.org/2118563002
    Cr-Commit-Position: refs/heads/master@{#403392}
    ac799c2f
BUILD.gn 7.39 KB