• Wez's avatar
    [events] Allow null-named DomCodes to be mapped to/from native. · acd7b545
    Wez authored
    Previously NativeKeycodeToDomCode() would treat codes with a NULL name
    for the DomCode (i.e. DomCodes used internally by Chrome to represent
    keys with no standardized DOM |code| value.) as unknown.
    
    This has been work-around in the DomCode table by assigning non-NULL
    names to non-standard DomCodes, leading to confusion over which are
    standardized mappings, and which are Chrome-internal.
    
    Allow native keycodes with no standardized DOM |code| name to be mapped
    to their Chrome-internal DomCode value, so that non-standard keys may
    be switched to NULL names.
    
    Bug: 952051
    Change-Id: I1a08928765e76816410c3b005383b43910be5b51
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020928
    Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
    Reviewed-by: default avatarNavid Zolghadr <nzolghadr@chromium.org>
    Reviewed-by: default avatarDave Tapuska <dtapuska@chromium.org>
    Auto-Submit: Wez <wez@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#755499}
    acd7b545
keycode_converter_unittest.cc 9.86 KB