• Mansi Awasthi's avatar
    Embed element with child tree should not be treated as an empty object · acde38ba
    Mansi Awasthi authored
    Currently Embed element with children in different tree are treated as
    an empty object. It's because IsEmptyObjectReplacedByCharacter() calls
    AnchorUnignoredChildCount() to see if an element has any children. This
    call doesn't check if the element has a child tree. This results in
    incorrect range calculation for PDF documents.
    
    This CL adds a check in IsEmptyObjectReplacedByCharacter() that an Embed
    element with non empty children including child tree should not be
    treated as an empty object.
    
    Bug: 1131507
    Change-Id: I0fb2572a80c304c7cee35f68062321e09b78ed62
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449670
    Commit-Queue: Nektarios Paisios <nektar@chromium.org>
    Reviewed-by: default avatarNektarios Paisios <nektar@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#817501}
    acde38ba
ax_node_position_unittest.cc 486 KB