• Andrew Xu's avatar
    Check tablet mode controller pointer · ace43e3a
    Andrew Xu authored
    It is an issue reported by Fuzz. However, I cannot reproduce the issue
    through Fuzz on my work station although following the reproduction
    instructions (attached to the issue page) very carefully. Based on the
    call stack, the story should be:
    When destructing ash::Shell, all windows are destructed as well via
    Shell::CloseAllRootWindowChildWindows(). However, TabletModeController
    is destructed before window's destruction. Meanwhile, during window's
    destruction (like Hotseat), it may utilize TabletModeController.
    
    This CL serves as a quick fixing for M-83. Another issue (1067490) is
    created for the real fixing.
    
    Bug: 1066265
    Change-Id: I43a2f809facaad2254bd288716ca4742e76d471e
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132841
    Commit-Queue: Andrew Xu <andrewxu@chromium.org>
    Reviewed-by: default avatarMitsuru Oshima <oshima@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#756153}
    ace43e3a
scrollable_shelf_view.cc 85.6 KB