GitLab

ChallengeResponseAuthKeysLoader now waits until force-installed login
screen extensions are installed before requesting a certificate from
these extensions, avoiding an incorrect error message.

In order to know which extensions to wait for, stored
ChallengeResponseKeys now contain the id of the extension that signed
them.

ChallengeResponseAuthKeysLoader will only wait for 5 seconds, then the
error is displayed anyway (e.g. if the extensions failed to load).

This is a reland of
https://chromium-review.googlesource.com/c/chromium/src/+/2078584
which was reverted in
https://chromium-review.googlesource.com/c/chromium/src/+/2101749
since a test added in this CL was crashing in debug mode:
A ExtensionLoadObserver object which waits on the loading of extensions
would, when all extensions had already loaded, indirectly destroy
itself in the middle of the function StartWaiting(). This was fixed by
ensuring that the function returns after any call that might cause
immediate destruction of the object.

Test: Compile with is_debug=true and run the browser_tests in this CL.

Bug: 1052404
Change-Id: I5b564d05c5da0a075d94772e4698673dcd418cd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102651Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Commit-Queue: Fabian Sommer <fabiansommer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750935}