• Joel Hockey's avatar
    Fix removing spinner on crostini apps · ade8f1f7
    Joel Hockey authored
    We now only remove the spinner from crostini apps after the
    window is showing, and we ensure that the icon stays in the same
    position the whole time.
    
    In crrev.com/c/2294742, I changed to always call CloseSpinner when
    a crostini app is launched.  The result of this is that we were
    removing the spinner and icon from the shelf, and then the icon was
    being added back later (usually a few seconds) when the window appears.
    Note that it was possible that the shelf position could change if
    other apps were opened while the spinner was showing.
    
    Bug: 1132089
    Change-Id: I1b03c0df5f88ffa892d352b0fdfc36f93daa0a47
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532341
    Commit-Queue: Joel Hockey <joelhockey@chromium.org>
    Auto-Submit: Joel Hockey <joelhockey@chromium.org>
    Reviewed-by: default avatarTimothy Loh <timloh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#827670}
    ade8f1f7
crostini_util.cc 23.4 KB