• Daniel Bratell's avatar
    Removing unused private field from Windows NSSDecryptor · ae4c9257
    Daniel Bratell authored
    Coding standard and compiler do not like unused private fields, but
    sometimes they slip between the cracks until they trigger something:
    
    In file included from gen/chrome/utility/utility_jumbo_1.cc:12:
    In file included from .\../../chrome/utility/importer/firefox_importer.cc:26:
    In file included from ../..\chrome/utility/importer/nss_decryptor.h:13:
    ../..\chrome/utility/importer/nss_decryptor_win.h(169,29):  error: private field 'PK11_CheckUserPassword' is not used [-Werror,-Wunused-private-field]
      PK11CheckUserPasswordFunc PK11_CheckUserPassword;
                                ^
    1 error generated.
    
    This removes the unsued field. Also removing an "explicit" to get past
    presubmit checks.
    
    Running presubmit upload checks ...
    
    L: \src\clean_chromium\src\chrome\utility\importer\nss_decryptor_win.cc:18:  Zero-parameter constructors should not be marked explicit.  [runtime/explicit] [5]
    Change-Id: Id310c0f65a406c1a47ec29312472580d15dfd1ce
    Reviewed-on: https://chromium-review.googlesource.com/c/1259018
    Commit-Queue: Ilya Sherman <isherman@chromium.org>
    Reviewed-by: default avatarIlya Sherman <isherman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#596375}
    ae4c9257
nss_decryptor_win.cc 6.25 KB