• K Moon's avatar
    Fix PreviewModeClient::ProposeDocumentLayout() DCHECK · aee0742f
    K Moon authored
    crrev.com/700518 incorrectly assumed
    PreviewModeClient::ProposeDocumentLayout() could not be reached. In
    fact, the PreviewModeClient is used only when previewing non-PDF
    documents with more than 1 page.
    
    This change also adds a browser test to check the behavior of the print
    preview dialog when printing multiple pages: Current print preview tests
    only generate a single page, which fails to exercise this issue.
    
    The crash occurs after the print preview is "ready" (all pages have been
    rendered), but before the print preview dialog has "loaded" completely.
    Current tests only wait for the "ready" condition, but the new test must
    wait for the "loaded" condition. Since fully loading is slow, most tests
    continue waiting only for the "ready" condition.
    
    Bug: 885110
    Change-Id: I20316fd658d5a125a13f08d07ced4dd79884fac7
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835211
    Auto-Submit: K Moon <kmoon@chromium.org>
    Commit-Queue: K Moon <kmoon@chromium.org>
    Reviewed-by: default avatarLei Zhang <thestig@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#702190}
    aee0742f
print_browsertest.cc 24.6 KB