-
Wei Li authored
This reverts commit 2093bb8f. Reason for revert: The last flaky test shown in crbug.com/817068 is before the fix https://chromium.googlesource.com/chromium/src.git/+/788c11139b869d1fc5b82cbbd238af2fd543535e. According to flaky dashboard, there is no test failure from these browser tests after the fix landed. So it should be good to stay. Original change's description: > Revert "Print with dead subframes for pdf composition" > > This reverts commit d20c0123. > > Reason for revert: The SubframeUnavailableBeforePrint test added in this CL is flaky (see crbug.com/817068). > > Original change's description: > > Print with dead subframes for pdf composition > > > > Handle two cases with dead subframes for pdf composition: > > -- When a web page has a dead subframe prior to printing, we need to > > detect the liveness of the subframe, and avoid requesting printing for > > such frame; > > -- If after we request printing a subframe, the subframe dies, we add > > monitoring for render frame's closed event to check whether it is one > > of our pending ones. If so, notify pdf compositor service about that. > > > > We add an interface in pdf compositor service to be notified about > > the frame's unavailability for either of the above cases. > > > > In this CL, we also add a map to record the subframes that are already > > printed and use it to avoid printing the same ones repeatedly. > > > > BUG=814086 > > > > Change-Id: Ibd69dd21a6498a5c2784dfe892bc5803e84fa6f0 > > Reviewed-on: https://chromium-review.googlesource.com/932018 > > Commit-Queue: Wei Li <weili@chromium.org> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Reviewed-by: Lei Zhang <thestig@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#539291} > > TBR=dcheng@chromium.org,thestig@chromium.org,weili@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > TBR=dcheng@chromium.org > > Bug: 814086 > Change-Id: I2062517c3f955523618be23a52ad507c4da3de90 > Reviewed-on: https://chromium-review.googlesource.com/941201 > Commit-Queue: Colin Blundell <blundell@chromium.org> > Reviewed-by: Colin Blundell <blundell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#539818} TBR=dcheng@chromium.org,thestig@chromium.org,weili@chromium.org,blundell@chromium.org Change-Id: Iab653dd94f117956059bf950a4c54fd133270c07 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 814086 Reviewed-on: https://chromium-review.googlesource.com/941501Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#539843}
af231fc6