• Xi Cheng's avatar
    Add test coverage for NotificationActivator::Activate in notification_helper · af44f46e
    Xi Cheng authored
    We introduce notification_helper_launches_chrome_unittest, which is evolution
    of notification_helper_process_unittest. In addition to testing the launch of
    notification_helper by the OS which is notification_helper_process_unittest
    all about, the new unit test also tests if chrome.exe can be successfully
    launched by notification_helper.exe via the NotificationActivator::Activate
    function.
    
    This new unit test is compiled into unit_tests.exe under chrome rather than
    notification_helper_unittests.exe. This is because unit_tests.exe has data
    dependency on chrome.exe which is required by this new unit test, and it's
    undesired to make notification_helper_unittests.exe have data dependency on
    chrome.exe.
    
    Bug: 734095
    Change-Id: I07ac90a84d7f885a359867f79ce613a194e0bb64
    Reviewed-on: https://chromium-review.googlesource.com/1002132
    Commit-Queue: Xi Cheng <chengx@chromium.org>
    Reviewed-by: default avatarGreg Thompson <grt@chromium.org>
    Reviewed-by: default avatarPeter Beverloo <peter@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#551540}
    af44f46e
BUILD.gn 281 KB