• Etienne Bergeron's avatar
    Enable HandlerVerifier on dcheck builds only · af4f12ef
    Etienne Bergeron authored
    The HandleVerifier is currently enabled on Canary and Dev channel.
    It is currently not running for a chrome developers local build.
    
    This CL enables the HandleVerifier for builds with DCHECK_ON. It will
    run on Canary builds for a reduced set of the population under the
    albatross build instead of on all Canary/Dev. This helps isolate the
    performance impact to builds with that intent in my mind and avoids
    polluting performance diagnosis tools.
    
    The developers can reproduce issues locally. A build with
    dcheck_always_on and supporting the IAT/EAT patching will run the
    HandleVerifier.
    
    R=wfh@chromium.org
    Bug: 1104342, 1103801
    
    Change-Id: Ie565dcc99c8c2faa27f61bcc4533bb48494c0492
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294562Reviewed-by: default avatarGreg Thompson <grt@chromium.org>
    Reviewed-by: default avatarWill Harris <wfh@chromium.org>
    Reviewed-by: default avatarGabriel Charette <gab@chromium.org>
    Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#795650}
    af4f12ef
scoped_handle_unittest.cc 4.49 KB