GitLab

This reverts commit e4effcd8.

Reason for revert: Suspect of causing consistent failure 

First failure: https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/49293

browser_tests on (none) GPU on Mac failed because of:
WebBluetoothTest.NavigateWithChooserCrossOrigin
SerialTest.NavigateWithChooserCrossOrigin
WebUsbTest.NavigateWithChooserCrossOrigin


[ RUN      ] WebBluetoothTest.NavigateWithChooserCrossOrigin
[2504:3843:0415/131012.437247:WARNING:notification_platform_bridge_mac.mm(563)] AlertNotificationService: XPC connection invalidated.
../../chrome/browser/bluetooth/web_bluetooth_browsertest.cc:492: Failure
Value of: waiter->has_shown()
  Actual: false
Expected: true
Stack trace:
0   browser_tests                       0x0000000101095a49 (anonymous namespace)::WebBluetoothTest_NavigateWithChooserCrossOrigin_Test::RunTestOnMainThread() + 617
1   browser_tests                       0x0000000106fff6ee content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() + 718
2   browser_tests                       0x0000000106a5b62a ChromeBrowserMainParts::PreMainMessageLoopRunImpl() + 3994
...

Original change's description:
> device chooser: de-flake tests
> 
> Right now, the count of extant bubbles is used to keep track of
> how many bubbles exist. This leads to flaky tests though: the bubble's
> view is only deallocated after closing the bubble finishes, and since
> closing the bubble is async, whether the view has been deallocated or
> not at the end of the test is variable.
> 
> This change has the tests instead ensure that the close process has
> *started* at the end of the test, which is always true.
> 
> Bug: 1069695
> Change-Id: I29535149fd3f318c22b44d8f93d22c5b248816da
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149685
> Reviewed-by: Reilly Grant <reillyg@chromium.org>
> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#759330}

TBR=ellyjones@chromium.org,reillyg@chromium.org

Change-Id: I380bb34779c4623775826d02ce6bd10a7d1c6870
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1069695
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151507Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#759554}