GitLab

This is a reland of 8a905049

The issue was that settings_list->Get was in a DCHECK, meaning it was
never ran in non-debug builds. This fixes it by removing the DCHECK and
also uses GetList()::operator[] instead of
Get(size_t index, Value** out_value) since the later is deprecated.

Original change's description:
> Reuse upload browsertests for corresponding Enterprise Connectors
>
> This reuses tests by having the policy setters of
> DeepScanningBrowserTestBase set either legacy or Connector policies, and
> then making every upload browsertest parametrized with a bool so both
> policy sets get tested.
>
> The DeepScanningDialogViews test also change a bit, the ScanType test
> parameter is removed since this dialog doesn't depend on the type of
> scanning being done. This avoids having a very large number of
> combinations for that test that don't cover different code paths.
>
> Bug: 1076083
> Change-Id: I419b21de0095add8b5b214993be010d022941202
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210782
> Reviewed-by: Roger Tawa <rogerta@chromium.org>
> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#770745}

Bug: 1076083
Change-Id: I28eb4e2b9db730152c8c7f2a0a8404372ee00923
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211903Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771100}