GitLab

Currently, KeyboardUI has a weird interface where |GetKeyboardWindow|
will start loading the keyboard web page if it is called the first time.
So this resulted in a lot of places where we were calling
GetKeyboardWindow and didn't know whether it would cause a load or not.

We change the KeyboardUI interface a bit to explicitly state when we
are creating / loading a keyboard window, vs just getting an already
loaded one.

This removes ChromeKeyboardUIWebContent's dependency on
KeyboardController as well.

We tried to keep the same behaviour for existing KeyboardUI subclasses.

Bug: 845780
Change-Id: I3178c81c382f2c3cd8217eda5a0c9b9d489df5be
Reviewed-on: https://chromium-review.googlesource.com/c/1264336
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599772}