• Mason Freed's avatar
    [CI] Adding full lifecycle/raster during autoscroll/animation tests · b0855622
    Mason Freed authored
    Previous to this CL, these autoscroll/animation tests passed only because there
    is a default surface deadline (typically 4 frames) in place. Surface activation
    does not happen automatically, because in layout test mode, rasterization is not
    performed until the very end of the test, for image capture. For the tests in
    question, that deadline was previously always being hit, causing the surface to
    be activated, triggering the monitored scroll events and passing the test.
    
    When the --enable-display-compositor-pixel-dump flag is enabled, however, the
    default surface activation deadline is changed to be infinite (no deadline). As
    a result, all such autoscroll/animation tests fail.
    
    With this CL, those tests that looked at animation behavior have been modified
    to call a new continuouslyRunAnimations() javascript method, which sets a flag
    that causes full rasterization to be included in the lifecycle update that was
    already taking place. This triggers surface activation, and runs the
    animations, allowing these tests to pass even with an infinite deadline.
    
    Bug: 883547, 874162
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
    Change-Id: I0d9e1ae7d10fab186207cdfbc8e2f85f60d99f35
    Reviewed-on: https://chromium-review.googlesource.com/c/1229354
    Commit-Queue: Mason Freed <masonfreed@chromium.org>
    Reviewed-by: default avatarKent Tamura <tkent@chromium.org>
    Reviewed-by: default avatarPhilip Rogers <pdr@chromium.org>
    Reviewed-by: default avatarAntoine Labour <piman@chromium.org>
    Reviewed-by: default avatarTimothy Dresser <tdresser@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#595898}
    b0855622
middleClickAutoscroll-in-iframe.html 832 Bytes