-
Ehsan Chiniforooshan authored
We have TBMv2 versions of thread_times metrics, implemented in the Catapult repo in tracing/tracing/metrics/rendering. The legacy code for these metrics live in the Chromium repo in tools/perf/metrics/timeline.py. In order to not have a pause in the perf dashboard when we replace metrics defined in the Chromium repo with the ones defined in the Catapult repo, we plan to: 1- (this CL) modify the AddTBMv2RenderingMetrics function to behave when both metrics (with the same name) exist, 2- for all (groups of) thread times metrics: 2.1- rename the TBMv2 version, in the Catapult repo, to have the same name as the legacy metric, 2.2- delete the legacy metric, from the Chromium repo. 3- and, finally, delete the rendering measurement and rendering_util, and completely move to TBMv2. Bug: 890757 Change-Id: Iafb84d3ec0f732177005651e0b54b8dccb307c65 Reviewed-on: https://chromium-review.googlesource.com/c/1307838Reviewed-by:Ned Nguyen <nednguyen@google.com> Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Cr-Commit-Position: refs/heads/master@{#604592}
b130e085