• Martin Kreichgauer's avatar
    fido: make CtapMakeCredentialRequest carry the full UserVerificationRequirement · b1d355cb
    Martin Kreichgauer authored
    This adds a UserVerificationRequirement enum field to
    CtapMakeCredentialRequest. The existing "effective" user verification
    bool is removed and the computation of the effective value (required vs
    discouraged) is moved into FidoDeviceAuthenticator, in parallel to how
    this is handled for GetAssertion requests.
    
    This change makes the full uv requirement available to the Windows
    authenticators, and at the same time fixes a bug for device
    authenticators where requests with uv="preferred" would result in
    CTAP device requests with uv=false even for authenticators with UV
    support.
    
    Also rename CtapMakeCredentialRequest::resident_key_supported() to
    resident_key_required().
    
    Bug: 898718
    Change-Id: I80ba3f052f871dce711c15ed8659812ad7cab10b
    Reviewed-on: https://chromium-review.googlesource.com/c/1324379
    Commit-Queue: Martin Kreichgauer <martinkr@chromium.org>
    Reviewed-by: default avatarKim Paulhamus <kpaulhamus@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607074}
    b1d355cb
authenticator.cc 15.6 KB