-
Mark Schillaci authored
This CL is the seventh part of an effort to port the existing Desktop feature to Android. This feature enables a user to send an image to Google to process to generate a descriptive alt text if a website does not provide one. Design Doc: go/2020-q1-android-image-descriptions Slide Deck: go/clank-imageDescriptions Launch Bug: 1057168 Original Desktop Design Doc for reference: go/chrome-a11y-annotations-design This is a conservative approach, we use a separate set of profile Prefs for this feature rather than syncing with the Desktop Prefs. This can be updated in time as needed. ---------- This CL adds the following: - Syncs Regular and Incognito behavior as per new reqs - Corrects unit tests for above - Adds an AXMode observer to watch for screen readers being enabled - Adds TabModelObserver to proactively dismiss dialog on tab close ---------- This CL is expanded upon the original CL here: crrev.com/c/2585587 which was reverted here: crrev.com/c/2589933 Rather than a simple Reland, this CL is the original CL plus improvementss and a bug fix to prevent further issues. AX-Relnotes: Android accessibility image descriptions behavior in incognito tabs will now match the regular tabs behavior for that profile. Bug: 1057169, 1158342 Change-Id: I92d9dd87081ca9b7efb09be93ca32f9be7050768 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596417Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Mark Schillaci <mschillaci@google.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Mark Schillaci <mschillaci@google.com> Cr-Commit-Position: refs/heads/master@{#843359}
b226c0e8