• Mihai Sardarescu's avatar
    Reland "Use EarlGrey wait condition instead of spinning the runloop." · b28edfcf
    Mihai Sardarescu authored
    This reverts commit 9b7b1b3a.
    
    Reason for revert: Fixed downstream compilation
    
    Original change's description:
    > Revert "Use EarlGrey wait condition instead of spinning the runloop."
    > 
    > This reverts commit 7a4958d3.
    > 
    > Reason for revert: Downstream code is using signOutAndClearAccounts
    > 
    > Original change's description:
    > > Use EarlGrey wait condition instead of spinning the runloop.
    > > 
    > > The sign-in external URL tests were spinning the runloop while waiting
    > > for the identities to be removed from the ChromeIdentityService. This
    > > was consistently failing with EarlGrey2.
    > > 
    > > This CL uses an EarlGrey wait condition instead of spinning the runloop
    > > while waiting for the identities to be removed.
    > > 
    > > Bug: 1031986
    > > 
    > > Change-Id: I0bcf6bda55caa506fe3a4d54ee607efc5c2e4d37
    > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039551
    > > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
    > > Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#738916}
    > 
    > TBR=msarda@chromium.org,sdefresne@chromium.org
    > 
    > Change-Id: I87b517b4669f02af19c516997eba465f51eb0c22
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Bug: 1031986
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041753
    > Reviewed-by: Gauthier Ambard <gambard@chromium.org>
    > Commit-Queue: Gauthier Ambard <gambard@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#738934}
    
    TBR=msarda@chromium.org,sdefresne@chromium.org,gambard@chromium.org
    
    Change-Id: I5be4d0bad2ac69aade4f9707a55303608bfa3644
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 1031986
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041598Reviewed-by: default avatarMihai Sardarescu <msarda@chromium.org>
    Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#738940}
    b28edfcf
chrome_test_case.mm 15.9 KB