• David Bokan's avatar
    Performance fix for top controls-affected raster · b2d41071
    David Bokan authored
    In https://crrev.com/77b67445ba6e415e8b41b5b6fd5c016c7195206d I changed
    PictureLayerImpl::UpdateViewportRectForTilePriorityInContentSpace by the
    "live" bounds-delta, which is the exact amount that the browser controls
    have been hidden by. Prevoiusly, this method would expand by the entire
    top controls height.
    
    That CL caused the linked performance regression. I suspect this happens
    because we would progressively raster slightly more of the layer, rather
    than rastering the entire browser-controls based bar in one shot. This
    CL goes back to expanding the visible rect by the entire
    browser-controls height rather than using the amount-hidden.
    
    Bug: 890870
    Change-Id: Id3a2b019e394005fe4434b7b6bf4a37f81f4550c
    Reviewed-on: https://chromium-review.googlesource.com/c/1297281Reviewed-by: default avatarvmpstr <vmpstr@chromium.org>
    Commit-Queue: David Bokan <bokan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#603130}
    b2d41071
picture_layer_impl.cc 71 KB