• Yuke Liao's avatar
    Reland "[lacros] Support mojo connection in testing environment" · b2f9cb37
    Yuke Liao authored
    This reverts commit a3e6095c.
    
    Reason for revert: Fix test flakiness
    
    Original change's description:
    > Revert "[lacros] Support mojo connection in testing environment"
    > 
    > This reverts commit 44a2bf3d.
    > 
    > Reason for revert: New test times out.
    > https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/38462
    > 
    > Original change's description:
    > > [lacros] Support mojo connection in testing environment
    > > 
    > > This CL supports setting up mojo connection between lacros and ash in
    > > testing and debugging environment, and it is done via a unix domain
    > > socket.
    > > 
    > > Unix domain socket is only used in testing, not production because it
    > > allows a random process to connect to ash-chrome as long as it knows
    > > the socket path.
    > > 
    > > Currently, only one lacros-chrome is allowed to connect to ash-chrome,
    > > so in the testing environment, test launcher will run tests serially,
    > > and will change to run in parallel once ash-chrome supports multiple
    > > clients.
    > > 
    > > Bug: 1120582
    > > Change-Id: I9736b03218f8fe937a7d642a35d6ee49b7e081f6
    > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384543
    > > Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
    > > Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
    > > Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#805537}
    > 
    > TBR=jorgelo@chromium.org,hidehiko@chromium.org,liaoyuke@chromium.org
    > 
    > Change-Id: I911a4d8bd80e8f0a217243503986a1a6d4a16338
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Bug: 1120582
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403460
    > Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
    > Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#805696}
    
    TBR=jorgelo@chromium.org,hidehiko@chromium.org,liaoyuke@chromium.org,mstensho@chromium.org
    
    # Not skipping CQ checks because this is a reland.
    
    Bug: 1120582
    Change-Id: I3cf4c46e939ee71e57b30d435da58bd23d15c02a
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404684Reviewed-by: default avatarYuke Liao <liaoyuke@chromium.org>
    Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#805985}
    b2f9cb37
chromeos_switches.h 14.7 KB