GitLab

This CL introduces a new API
FaviconServiceImpl::AddPageNoVisitForBookmark()

Similar to other APIs in FaviconService, it acts as a proxy to the
underlying HistoryService.

This comes with the following benefits:

1- Reduces number of dependencies for the calling sites. They now
depend only on FaviconService.

2- There exist a mock for FaviconServiceImpl which isn't the case for
HistoryService. Tests inject null HistoryService, but instead they
could directly use the MockFaviconService and no need to checks
for null history service in production code.

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I641bf257c1e24c4b3663bcd3cf7210e8d1363002
Reviewed-on: https://chromium-review.googlesource.com/1161932
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580773}