GitLab

This CL dismantles the side effect constructor blacklist, so Blink constructors
(default, named, custom) all throw when evaluating with throwOnSideEffect.
[Affects=Everything] is no longer a valid extended attribute.

Constructors can still be invoked without side effects in one case: creating a
DOM wrapper for the V8 object. Any whitelisted attribute/operation that returns
an HTMLDivElement, for example, can call the constructor with
ConstructorMode::kWrapExistingObject the first time it returns.

Bug: 829571
Change-Id: I3ed2166da80d38a7835dc57a1ccaec23e22734e9
Reviewed-on: https://chromium-review.googlesource.com/1043655Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558134}