• Stephane Zermatten's avatar
    [Autofill Assistant] Slim down AutofillAssistantUiController. · b3c1d9dd
    Stephane Zermatten authored
    This patch take out initialization and delayed shutdown from
    AutofillAssistantUiController:
    
     * initialization goes into a new class AutofillAssistantFacade, called
       from CustomTabActivity.
    
     * UiDelegateHolder becomes a toplevel class, responsible for delayed
       shutdown and UI pausing
    
    The following responsibilities remain in AutofillAssistantUiController:
    
     * bridging Java -> C++ and C++ -> Java
     * account management and authentication
    
    This patch also unifies the way the "give up" message is displayed in
    Java, removes the unnecessary C++ OnGiveUp method and always hides the
    overlay and the event filter when switching to graceful shutdown mode.
    
    Bug: 806868
    Change-Id: Idef806520f5e6e8a6dda4fc843d61bf77c1eafb4
    Reviewed-on: https://chromium-review.googlesource.com/c/1333652
    Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
    Reviewed-by: default avatarEgor Pasko <pasko@chromium.org>
    Reviewed-by: default avatarMathias Carlen <mcarlen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608007}
    b3c1d9dd
ui_controller_android.cc 15.6 KB