GitLab

This reverts commit 635cbc1a.

Reason for revert: suspect causing views_unittests failure on Linux ChromiumOS MSan Tests
---
BoxLayoutViewTest.NoLayoutInvalidationWhenPropertyUnchanged
BoxLayoutViewTest.LayoutInvalidationWhenPropertyChanged
---

First test failure: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/20798

Sample log: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8867505219215733920/+/steps/views_unittests/0/logs/Deterministic_failure:_BoxLayoutViewTest.LayoutInvalidationWhenPropertyChanged__status_CRASH_/0
---
 [ RUN      ] BoxLayoutViewTest.LayoutInvalidationWhenPropertyChanged
 ==11171==WARNING: MemorySanitizer: use-of-uninitialized-value
     #0 0x5570eca375a3 in testing::AssertionResult testing::internal::CmpHelperNE<int, int>(char const*, char const*, int const&, int const&) ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:1638
     #1 0x5570eca375a3 in ?? ??:0
     #2 0x5570ed05abfe in views::BoxLayoutViewTest_LayoutInvalidationWhenPropertyChanged_Test::TestBody() ./../../ui/views/layout/box_layout_view_unittest.cc:78
---

Original change's description:
> Views: Add BoxLayoutView
>
> This CL adds class member getters and setters to the BoxLayout class
> where needed for the BoxLayoutView properties. Adds a TODO to ensure
> layout is invalidated when these members are set.
>
> Bug: None
> Change-Id: I13d73c75ca93f9de391b46c7241682ee7ced9a89
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434561
> Reviewed-by: Wei Li <weili@chromium.org>
> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#813351}

TBR=weili@chromium.org,tluk@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: None
Change-Id: I4683ac2a66b75c98da6adf20a80636fb6486aeef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2448573Reviewed-by: Takashi Sakamoto <tasak@google.com>
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/heads/master@{#813619}