• Alan Cutter's avatar
    Reland "Move ManifestUpdateManager and ManifestUpdateTask into web_application:common" · b4470a7c
    Alan Cutter authored
    This reverts commit 1f961201.
    
    Reason for revert: Speculative suspicion this CL didn't cause the fuchsia failures.
    
    BUG=1044617e
    
    Original change's description:
    > Revert "Move ManifestUpdateManager and ManifestUpdateTask into web_application:common"
    >
    > This reverts commit 68ea97aa.
    >
    > Reason for revert: Speculative; suspected root cause of Deterministic Fuchsia failures.
    >
    > BUG=1044617e
    >
    > Original change's description:
    > > Move ManifestUpdateManager and ManifestUpdateTask into web_application:common
    > >
    > > ManifestUpdateManager and ManifestUpdateTask are not used outside of
    > > web_applications and are not isolated components, they should live one
    > > level up while maintaining independence from the BMO/Extension backend.
    > >
    > > This CL is in preparation to add a dependency from
    > > ManifestUpdateManager to SystemWebAppManager.
    > >
    > > Bug: 1035242
    > > Change-Id: I3a5e8e691079619e5b063ac90653dcae6ee3f76f
    > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1973441
    > > Auto-Submit: Alan Cutter <alancutter@chromium.org>
    > > Commit-Queue: Alexey Baskakov <loyso@chromium.org>
    > > Reviewed-by: Alexey Baskakov <loyso@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#733898}
    >
    > TBR=alancutter@chromium.org,loyso@chromium.org
    >
    > Change-Id: Ie1a4f075a6515b85effd5c853b82d7daeb2aa7b9
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Bug: 1035242
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014922
    > Reviewed-by: Olga Sharonova <olka@chromium.org>
    > Commit-Queue: Olga Sharonova <olka@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#734033}
    
    TBR=alancutter@chromium.org,loyso@chromium.org,olka@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 1044617e, 1035242
    Change-Id: I903e50bfdb95d7f703384a42dd09c177a9cdf5a0
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029530Reviewed-by: default avatarAlan Cutter <alancutter@chromium.org>
    Reviewed-by: default avatarAlexey Baskakov <loyso@chromium.org>
    Commit-Queue: Alexey Baskakov <loyso@chromium.org>
    Auto-Submit: Alan Cutter <alancutter@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#737118}
    b4470a7c
manifest_update_manager.cc 7.02 KB