• Ken Rockot's avatar
    [mojo] Tweak oversized IPC crash dumps · b4980855
    Ken Rockot authored
    Crash dumping for oversized IPCs was recently moved to serialization
    instead of transmission. However it turns out that CommitSize is
    called at the very end of serialization, which might not be finalized
    until just before transmission anyway.
    
    Dumping in AppendMessage instead of CommitSize means catching
    errors earlier in serialization where we consistently have a
    useful stack trace to work with.
    
    Fixed: 1121073
    Change-Id: I8aba6d08625af40b8b34329003ff736729f8a1b6
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372882
    Auto-Submit: Ken Rockot <rockot@google.com>
    Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
    Reviewed-by: default avatarOksana Zhuravlova <oksamyt@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#801199}
    b4980855
user_message_impl.cc 25.6 KB