• Mikel Astiz's avatar
    Avoid late keyed services with TestingProfile · b535c2a0
    Mikel Astiz authored
    This patch migrates tests away from deprecated APIs and adopts
    TestingProfile::Builder for tests in
    /chrome/browser/browsing_data.
    
    Rationale: creating or overriding keyed services after the profile has
    been created is problematic and known to cause hard-to-debug test
    flakiness, because it bypasses BrowserContextDependencyManager and often
    leading to use-after-free.
    
    This CL was uploaded by git cl split.
    
    R=dullweber@chromium.org
    
    Bug: 1106699
    Change-Id: Idea748f489836737cfd60e5e8c4ad98662103680
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315354
    Auto-Submit: Mikel Astiz <mastiz@chromium.org>
    Reviewed-by: default avatarChristian Dullweber <dullweber@chromium.org>
    Commit-Queue: Christian Dullweber <dullweber@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#791769}
    b535c2a0
bookmark_counter_unittest.cc 4.56 KB