-
Maxime Charland authored
The new illustrated empty state in Bookmarks root will happen when a user does not have any bookmarks or folder. This means that the Mobile Bookmarks folder will not be created when it is empty. In addition to this change, a few other changes are needed : - The Mobile Bookmarks TableViewItem should not be created if the folder is empty. - When the state of the Sign In Promo is changed, the TableView background should be updated. - When a bookmark is deleted, the root TableView should be updated to display an empty state if the user has deleted their last bookmark. - Because the empty state is loaded right after Chrome has finished loading the user's bookmarks, there is a possibility that the spinnerView is no longer the background view when the spinnerView has finished its animation. Therefore, we should only remove the TableView background if the spinnerView is still the active background. (Googlers only links) Screenshot: https://drive.google.com/file/d/1gzEm1IazTYK23UispwRF4zNQIn6Dd3f-/view?usp=sharing Design Doc for Chrome Empties: https://docs.google.com/document/d/1JM2sKT4oghkol51U7_3xv9sfaB26C89CCGa2uwYBgsI/edit?usp=sharing Mocks of the new Chrome Empties look: https://docs.google.com/presentation/d/1x1lSTOSQ1zkJu87SoigiUhX2f9oHACglR22yYg-lSHo/edit?usp=sharing Bug: 1098328 Change-Id: I05d7938d7193e6dfd34d075778eee0dd3b75003c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304536 Commit-Queue: Maxime Charland <mcharland@google.com> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#792267}
b5443388