• Lukasz Anforowicz's avatar
    Install |pending_loader_factories_| slightly earlier. · b5592721
    Lukasz Anforowicz authored
    This CL tries to speculatively avoid 1) cases where a
    |direct_network_factory_| might be getting used with non-opaque origins
    (see https://crbug.com/1105794) and 2) cases where a
    |request_initiator_site_lock| doesn't match |request_initiator|.  We
    speculate that one such case might occur when
    RenderFrameObserver::ReadyToCommitNavigation triggers a fetch in a new
    document *before* the new factories have been installed.
    
    After this CL, the new factories are installed earlier, before calling
    RenderFrameObserver::ReadyToCommitNavigation.
    
    Bug: 1105794, 1098938, 920634, 1056949
    Change-Id: I1f06750d4211e12d196eba0f3a78edeaeaa98cdf
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303678
    Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
    Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org>
    Reviewed-by: default avatarNasko Oskov <nasko@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#789714}
    b5592721
render_frame_impl.cc 264 KB