-
ckitagawa authored
This CL attempts to re-implement ui/base/clipboard/clipboard_android_unittests.cc which was deleted in http://crrev.com/2839753007 as part of removing GetApplicationContext. This CL does 2 things 1. clipboard_unittests.cc was made part of interactive_ui_tests (for context see crbug/434620); however, this target is not run on Android. Since gtests aren't sharded on Android (no clipboard contention) we can include clipboard_unittests.cc in an Android specific target to cover clipboard_android.{h|cc}. Note that this requires disabling some tests in clipboard_test_template.h that work with TestClipboard but not ClipboardAndroid (see inline bugs). 2. This adds the Android platform specific ClipboardAndroidTest.java with a testcase that simulates another application copying to the clipboard and correctly propagating that to Chrome's clipboard. This test needs to be driven from Java as per the re-implementation discussion in crbug/715619. Also related from crbug/434620 is the request for a last modified time testcase. However, this appears to reference preference-related functions which no longer exist. Bug: 434620, 715619, 1064968 Change-Id: I5e1b74711c638b947dde0dd205f575dd07cdb436 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121045 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Gang Wu <gangwu@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#755345}
b56f77e5