• Jennifer Apacible's avatar
    [Picture in Picture] Don't reset PiP ID when media is destroyed. · b5ec5693
    Jennifer Apacible authored
    Currently, we reset the media ID associated with Picture-in-Picture
    when OnMediaDestroyed is called, which includes when the video stops
    playing. This causes crashes when we attempt to control the video from
    the Picture-in-Picture window, such as play/pause and close.
    
    This also means that even if we leave Picture-in-Picture mode, the
    video media player will still show the Picture-in-Picture interstitial
    because the WebMediaPlayer isn't updated with the fact we've left
    Picture-in-Picture mode.
    
    It is okay to keep the id around; when another video is PiP'd, the ID
    will be updated.
    
    BUG: 726619
    Change-Id: I0e665047b85f20bc7bb9795273a5640460e7612f
    Reviewed-on: https://chromium-review.googlesource.com/1026974Reviewed-by: default avatarKinuko Yasuda <kinuko@chromium.org>
    Reviewed-by: default avatarDale Curtis <dalecurtis@chromium.org>
    Commit-Queue: apacible <apacible@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#553723}
    b5ec5693
media_web_contents_observer.cc 15.2 KB