-
Findit authored
This reverts commit 0823dbae. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 839992 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMDgyM2RiYWVhZDc0YjM0NmE3NWQ2NTNlNjVhYjkwYjAyNzc5ZDNhNgw Sample Failed Build: https://ci.chromium.org/b/8859069977390233904 Sample Failed Step: content_browsertests Sample Flaky Test: All/StartupTracingTest.TestEnableTracing/6 Original change's description: > [tracing] Align --trace-startup and --enable-tracing. > > Use StartupTracingController both for --trace-startup (primary use case: > browser startup perf profiling) and --enable-tracing (primary use case: > browser test tracing). > > Due to historical reasons both flags are kept, but now their behaviour > is mostly the same. If both are present, --trace-startup takes > precedence. > > Differences: > - `trace-startup` finishes after 5 seconds by default, while `enable-tracing` > continues until the browser is closed. (--trace-startup-duration overrides > both). > - `trace-startup-file` always treats the path as absolute, while if > `enable-tracing-output` ends with /, it uses the provided value as the > directory and generates the base name based on the current runtime > metadata. > > R=skyostil@chromium.org,eseckler@chromium.org > BUG=1157954 > > Change-Id: Ia76316aa8927b431784e2fb94c8e42e4e2c0b479 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589834 > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Reviewed-by: Eric Seckler <eseckler@chromium.org> > Commit-Queue: Alexander Timin <altimin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#839992} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=1157954 Change-Id: I089e53e58934bb503f087b1c8e3ef42c6d3df694 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609585 Cr-Commit-Position: refs/heads/master@{#839997}
b627347a
