• James Darpinian's avatar
    Revert "GPU: Remove transfer buffer autoflushing." · b63225bb
    James Darpinian authored
    This reverts commit dcfaac01.
    
    Reason for revert: Regressed canvas 2d performance in some MotionMark
    tests. Will redo as a WebGL-specific change.
    
    Original change's description:
    > GPU: Remove transfer buffer autoflushing.
    > 
    > This is change #2 of 3 reducing context switching during WebGL
    > rendering. On tiled rendering GPUs context switches are slow and can
    > even cause multisampling artifacts. Every time the command buffer is
    > flushed, a context switch is possible.
    > 
    > Before, the transfer buffer would flush the command buffer after an
    > arbitrary number of bytes were sent. This change removes that threshold.
    > Any performance benefit of early flushing is killed by the additional
    > context switching.
    > 
    > Bug: 828363,835353
    > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    > Change-Id: I8f71668d4b976332820d290868282d41286ab4fe
    > Reviewed-on: https://chromium-review.googlesource.com/1077568
    > Commit-Queue: James Darpinian <jdarpinian@chromium.org>
    > Reviewed-by: Antoine Labour <piman@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#563404}
    
    TBR=piman@chromium.org,jdarpinian@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 828363, 835353, 849348
    Change-Id: Iba27bae33f5395333f54db4bea4e79e41cca7e31
    Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
    Reviewed-on: https://chromium-review.googlesource.com/1087370
    Commit-Queue: James Darpinian <jdarpinian@chromium.org>
    Commit-Queue: Kenneth Russell <kbr@chromium.org>
    Reviewed-by: default avatarKenneth Russell <kbr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#565006}
    b63225bb
transfer_buffer_unittest.cc 18.7 KB