GitLab

base::GenerateGUID() produces lower-case GUIDs and they should get
exposed to the sync protocol exclusively in this canonical form to avoid
running into issues.

This patch replaces all occurrences in sync codebase with:
git grep -l 'IsValidGUID' -- components/sync* | \
  xargs sed -i 's/IsValidGUID/IsValidGUIDOutputString/g'

In addition, the implicit GUIDs used for bookmark sync, in particular
for permanent nodes, are updated to adopt lower-case GUIDs. These are
never committed to the server so there are no backward-compatibility
considerations.

Change-Id: I0d0468f3475e1a27a161e2af15853c757f53e201
Bug: 978430
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054154Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741381}