• Maksim Sisov's avatar
    Reland "xvfb: Wait for ReparentNotify before executing tests." · b6f63e3e
    Maksim Sisov authored
    This is a reland of 2fb9ab54:
    
    FIX: change test type from windowed to console for
    midi_unittests
    
    Original change's description:
    > xvfb: Wait for ReparentNotify before executing tests.
    >
    > X11 tests can fail because start up of OpenBox is not
    > synchronous and it is unknown when exactly it starts up.
    >
    > That results in a client that uses X11 missing events
    > and flakiness of tests.
    >
    > Thus, to avoid that issue, use a small program that
    > creates a dummy X11 windows and waits for the
    > ReparentNotify event. That is, OpenBox decorates
    > all the windows once it is initialized that results
    > in that event. Once the event is received, we can
    > be sure that the WM is up and running, and tests
    > can be executed.
    >
    > Bug: 1078771
    > Change-Id: Ic6fae30a706a6b9c32e4670da56457c833b4b7f9
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214526
    > Reviewed-by: Nico Weber <thakis@chromium.org>
    > Reviewed-by: Dirk Pranke <dpranke@chromium.org>
    > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
    > Commit-Queue: Maksim Sisov <msisov@igalia.com>
    > Cr-Commit-Position: refs/heads/master@{#775001}
    
    Bug: 1078771
    Change-Id: I500da8725f1c2d51788fd529d7c45318e5f93a03
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230463
    Commit-Queue: Maksim Sisov <msisov@igalia.com>
    Reviewed-by: default avatarDirk Pranke <dpranke@google.com>
    Reviewed-by: default avatarNico Weber <thakis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#776886}
    b6f63e3e
mb.py 74.8 KB