• Fergal Daly's avatar
    Reland "[Paint Preview] Post task captured callback" · b7abbb3d
    Fergal Daly authored
    This is a reland of c669ac6b
    
    This is only the fix and not the test.
    
    Original change's description:
    > [Paint Preview] Post task captured callback
    >
    > This CL attempts to fix a bug where calling
    > WebContents::DecrementCapturerCount in the callback passed to
    > PaintPreviewClient can result in reloading a crashed render frame.
    > This is problematic and crashes if it occurs inside RenderFrameDeleted
    > and PaintPreviewClient::OnFinished is invoked. By posting the callback
    > it should be invoked after RenderFrameDeleted cleanup is done resulting
    > in DecrementCapturerCount no longer being called inside
    > RenderFrameDeleted.
    >
    > Bug: 1146573
    > Change-Id: Iccb612d89135e058d8fc06de018e7c95cd91657a
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595247
    > Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
    > Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org>
    > Reviewed-by: Mehran Mahmoudi <mahmoudi@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#837649}
    
    Bug: 1146573
    Change-Id: I19623734e3c16b8646c286f47420a432647e0e24
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596727
    Auto-Submit: Fergal Daly <fergal@chromium.org>
    Reviewed-by: default avatarMehran Mahmoudi <mahmoudi@chromium.org>
    Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org>
    Commit-Queue: Fergal Daly <fergal@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#838141}
    b7abbb3d
paint_preview_client.cc 22.4 KB